-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TLS parameters inside if statements #881
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please sign CLA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question, non blocking.
@@ -165,8 +165,8 @@ redpanda.yaml: | | |||
port: {{ $listener.port }} | |||
{{- end }} | |||
{{- end }} | |||
admin_api_tls: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, nothing will break if this is empty nor if this is left out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this is the case, which is surprising to me as it could result in an empty section in the yaml. I'm not sure why disabling TLS works without the change in this PR.
@ivotron Could you help in the problem of CLA boot confusion? |
that's a race we've seen elsewhere. fine to ignore since we have that green one |
a9a8cff
to
4101cf8
Compare
Small change to move the start of the two TLS sections
admin_api_tls
andkafka_api_tls
into their associated if statement.