Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide client certs to servicemonitor CRDs #687

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

provide client certs to servicemonitor CRDs #687

wants to merge 3 commits into from

Conversation

gugu
Copy link

@gugu gugu commented Aug 27, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

alejandroEsc
alejandroEsc suggested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, and i have to say great suggestion for an improvement!

charts/redpanda/templates/servicemonitor.yaml
@@ -38,10 +38,22 @@ spec:
scheme: https
tlsConfig:
insecureSkipVerify: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we skip this if we are applying the certs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes HTTPS request to IP address (without hostname) and check SANs for the certificate (and it does not match)

charts/redpanda/templates/servicemonitor.yaml
@@ -38,10 +38,22 @@ spec:
scheme: https
tlsConfig:
insecureSkipVerify: true
ca:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if CA is enabled right? That is an option in the certs stanza of the values file.

charts/redpanda/templates/servicemonitor.yaml
@@ -38,10 +38,22 @@ spec:
scheme: https
tlsConfig:
insecureSkipVerify: true
ca:
secret:
name: {{ template "redpanda.fullname" $ }}-default-cert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default name in most cases, but not necessarily, we should check to see if a secret is being provided instead also.

@gugu gugu requested a review from chrisseto as a code owner April 11, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandroEsc alejandroEsc alejandroEsc requested changes

@joejulian joejulian Awaiting requested review from joejulian

@RafalKorepta RafalKorepta Awaiting requested review from RafalKorepta RafalKorepta is a code owner

@chrisseto chrisseto Awaiting requested review from chrisseto chrisseto is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gugu @CLAassistant @alejandroEsc