Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service accounts #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Scroul
Copy link
Contributor

@Scroul Scroul commented Dec 2, 2022

Not sure if you want this level of configuration for service accounts but I am running the chart in a service mesh so need good control over the service account.

I can add/remove some parts if you feel that you only want a part of this.

With this keeping serviceAccount in values as it is now will put serviceAccountName: default so it will work as before if you do not use any of the new yaml values.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joejulian
Copy link
Contributor

Would you mind opening an issue to associate with this that describes the symptoms you encounter with using a service mesh without this change? It would be really helpful for our docs team to be able to understand when and how this feature is used.

@Scroul
Copy link
Contributor Author

Scroul commented Dec 5, 2022

I added #225 explaining how this can be used in a service mesh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants