redpanda: fix out of range slice in go mode #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a slice operation that could generate a panic when run as go code if a string was less than 49 character in length. It has no effect on the transpiled templates as `substr` appropriately handles out of bounds slices. Ideally, this commit would modify `TestTemplate` to additionally run the go chart as well however doing so surfaced other issues with `helmette.Tpl`. See K8S-468.
chrisseto
requested review from
RafalKorepta and
andrewstucki
as code owners
andrewstucki
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a slice operation that could generate a panic when run as go code if a string was less than 49 character in length. It has no effect on the transpiled templates as
substrappropriately handles out of bounds slices.Ideally, this commit would modify
TestTemplateto additionally run the go chart as well however doing so surfaced other issues withhelmette.Tpl. See K8S-468.