C++: accessors for custom attributes #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom attributes are only settable when building a schema. There was previously no way to get the attributes from a parsed schema. This will be useful for reading Iceberg manifests, since we'll want to pull the field ids for each type.
dotnwat
approved these changes
Aug 22, 2024
jcipar
approved these changes
Aug 22, 2024
Yea, I'm not a fan, but you're right I did this to match the naming convention in the codebase. |
andrwng
merged commit 3bbe748
into
redpanda-data:release-1.12.0-redpanda
1 check passed
andrwng
added a commit
to andrwng/redpanda
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom attributes are only settable when building a schema. There was previously no way to get the attributes from a parsed schema. This will be useful for reading Iceberg manifests, since we'll want to pull the field ids for each type.