feat: add support for chunked uploading #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested manually with GIF images, but no automated tests in this I hereby declare that this contribution is licensed under Apache License Version 2
|
Kudos, SonarCloud Quality Gate passed! |
|
Hello, |
Just driving by my friend. But getting a release that can let me tweet gifs would be much appreciated, do whatever you want with the PR |
|
To clarify, I don’t have the headspace to determine what the idiomatic way of handling the interrupted exception is in your library. Probably quicker if you just push the way you want it on top. This PR should allow edits from maintainers, and I am happy for you to align the code with your style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested manually with GIF images, but no automated tests in this
I hereby declare that this contribution is licensed under Apache License Version 2
@redouane59 feel free to rework however you need. Should fix #183 and #281 but is hacky and not my best code