Use timer for background PINGs instead of a long-live goroutine #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoulPancake
commented
Feb 14, 2025
| @@ -323,7 +323,7 @@ func _newPipe(connFn func() (net.Conn, error), option *ClientOption, r2ps, nobg | |||
| p.background() | |||
| } | |||
| if p.timeout > 0 && p.pinggap > 0 { | |||
| go p.backgroundPing() | |||
| p.schedulePing(atomic.LoadInt32(&p.recvs)) | |||
There was a problem hiding this comment.
Any idea how we should benchmark this? @rueian
There was a problem hiding this comment.
I don't have a clear idea but I think we can first do a separate simulation of many <-ticker.C vs many time.AfterFunc to see if the latter really helps for memory usage and better scheduling on other goroutines. The simulation doesn't need to have rueidis involved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#757