-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics for tracking total disconnected time and reconnection attempts #3220
base: main
Are you sure you want to change the base?
Conversation
d41a0f7
to
e3fc47d
Compare
Considering adding a few more metrics
Those are implementation-specific and relevant to This raises some open questions: Do we continue with separate Metrics recorders, for example, one for ConnectionMonitoring (used by ConnectionWatchdog to track inactive connection time) and another for DefaultEndpoint (tracking the size of internal queues)... or have a single MetricsRecorder for both (ConnectionMonitoring, DefaultEndpoint)? Do we want to enable/disable only connection-related, and endpoint-related metrics separately? @tishun any opinion |
…size as micrometer metrics
7c0a5e0
to
3705008
Compare
bfbfd27
to
d9d70ec
Compare
- Bug: METRIC_RECONNECTION_INACTIVE_TIME is recorded on each attempt
8914047
to
37492c4
Compare
Description:
Introduces two new metrics to track the total time a connection remains disconnected until it is successfully reconnected and the number of reconnection attempts. The changes include:
lettuce.reconnection.inactive.duration
lettuce.reconnection.attempts
Impact: