Skip to content

ci(ghcr): add deploy on GitHub #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+40 −0
Open

ci(ghcr): add deploy on GitHub #441

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6404f8a
ci(ghcr): add deploy on GitHub
TartanLeGrand Apr 25, 2025
d582849
fix: branch
TartanLeGrand Apr 25, 2025
a6a6c13
fix: arm target platform
TartanLeGrand Apr 28, 2025
5ea92d3
ci: remove latest
TartanLeGrand Apr 28, 2025
19eeb8a
ci: add release/*
TartanLeGrand Apr 28, 2025
2e0000d
ci: add tags
TartanLeGrand Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/publish-to-ghcr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Publish Docker Images to GHCR

on:
push:
branches:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also trigger for release/* branches

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, what we want ?

  • Trigger on tags ?
  • Trigger on master ?
  • Trigger on release/* ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should trigger on pushes to master and release/* and tag with the commit SHA for the time being.

- master
- release/*
tags:
- '*'

jobs:
build-and-push:
name: Build and Push Docker Images
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Log in to GitHub Container Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Build and push Docker images
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We provide various platforms for our images, and this action seems like it would only push the amd64 architecture. What do you think about adding the rest of the archs, like we do on Dockerhub?

uses: docker/build-push-action@v4
with:
context: .
push: true
tags: |
ghcr.io/${{ github.repository_owner }}/redis:${{ github.sha }}
platforms: linux/amd64,linux/arm64