-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document aliases #535
base: master
Are you sure you want to change the base?
Document aliases #535
Conversation
Capturing my early thoughts here that I would like to have some discussion around...
We should definitely find those answers as a team. Regardless, I think this is a really good foundation to start from. |
I disagree with this, as the whole point is to create a very readable layer of resources that directly points to the git-structured content. Adding these ideas would mean we would not be able to tell the full structure of the content by looking at the tree. We could however add fields to any folders which are named based on products (for example), so that a product rename would be easily reflected in any content structure that is based off the modified entity.
This is not a bad diea. Part of the
|
I think there are tradeoffs both ways. If we set up the tree your way for maximum readability in composum, then we have data duplication in the system (product url fragments stored in at least 2 places) and we'll need to add extra logic for product renames to make sure that all entries get updated, and accept the risk that we may not get that logic 100% right. If we set up the tree my way, the tree becomes less readable through composum and our logic for exposing the mappings to users will have to do some extra translation. I think my way is safer from a data integrity perspective, but I do acknowledge that it complicates the system somewhat. I could be convinced that a url-changing product update is already a "big deal" anyways in that it will necessitate a mass rebuild or some such, and there will already be a fair bit of logic there anyway, so what's the harm in adding an extra few lines to update the redirect mapping tree as well? |
This change presents a more elegant approach to document access.
It introduces a "document alias" node type which when viewed is able to render the json or html content for any
Document
object in the system.This effectively creates a vanity url system that can be shaped in any way for callers to access the json or preview representations of the content.