GnuTLS/OpenSSL - signature_algorithms #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrc0mmand
force-pushed
the
gnutls-openssl-signature_algorithms
branch
from
593e31e to
e4d9ec1
Compare
tomato42
requested changes
Mar 29, 2017
| rlAssertGrep "Server Signature: ${S_NAME[$idx]}" "$rlRun_LOG" | ||
| rlAssertGrep "Client Signature: ${S_NAME[$idx]}" "$rlRun_LOG" | ||
|
|
||
| rlRun "kill $openssl_pid" 0,1 |
There was a problem hiding this comment.
what purpose has -verify_return_error if we then ignore server crashing/exiting because of errors?
There was a problem hiding this comment.
-verify_return_error won't close/crash the server if the client certificate is invalid, but yes, it would be wise to check for potential segfault after a successful handshake
| options+=(--x509certfile ${S_CLNT_CERT[$idx]}) | ||
| options+=(--x509keyfile ${S_CLNT_KEY[$idx]}) | ||
|
|
||
| rlRun -s "${options[*]} localhost < /dev/null" |
There was a problem hiding this comment.
why not a proper HTTP/1.1 request?
mrc0mmand
force-pushed
the
gnutls-openssl-signature_algorithms
branch
from
e4d9ec1 to
87e9960
Compare
|
Changes:
|
tomato42
reviewed
May 4, 2017
|
|
||
| rlJournalStart | ||
| rlPhaseStartSetup | ||
| rlAssertRpm $PACKAGE |
There was a problem hiding this comment.
When there's rlAssertRpm --all (below) there's no need for rlAssertRpm $PACKAGE
tomato42
approved these changes
May 5, 2017
|
We need to wait for 7.4 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new test, which tests signature_algorithms extension between GnuTLS and OpenSSL libraries. When client certificates are used, signature algorithms used for the client authentication are verified as well, even though they are not part of the signature_algorithms extension.
As this test requires TLSv1.2, whose implementation is not good enough in GnuTLS on RHEL 6, it's disabled by default on this OS version.
Unfortunately, it requires features from RHEL/CentOS 7.4, so it's going to fail until this version is released.