Issue Labelling Bugfixes #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to RPOPC-315 |
frival
approved these changes
Jan 28, 2025
kdvalin
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some errors with the Issue Labeling workflow. For one, it removes the
issue_commentdebug trigger mistakenly committed. Secondly it fixes a typo in a conditional causing it to never see that a PR has any related issues, causing failure.Before/After Comparison
Before
Issue Comment Errors
PR Failures
After
Issue comment trigger is removed, so the workflow will not be triggered on issue comments (or PR comments).
The conditional has been updated, causing failure only when it cannot find a parent issue.
Clerical Stuff
Issue: #158
Relates to JIRA: RPOPC-315