Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new task to request signature of blobs #550

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add new task to request signature of blobs #550

merged 1 commit into from
Dec 1, 2023

Conversation

ernesgonzalez33
Copy link
Contributor

  • Add request-signature-blob task to be able of using request-signature to sign a blob
  • Modify request-signature.py to sign container images and blobs depending of the arguments passed

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@ernesgonzalez33 ernesgonzalez33 force-pushed the add-request-signature-blob branch from 171ac0d to 7574ef1 Compare November 27, 2023 16:24
@ernesgonzalez33 ernesgonzalez33 marked this pull request as ready for review November 27, 2023 16:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@Allda Allda requested review from Allda and wcheang and removed request for Allda November 28, 2023 09:40
Allda
Allda approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Allda Allda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me. There are a couple of linting errors. Please review the output of the CI and fix the violations. I'll merge it when the pipeline passes.

@ernesgonzalez33 ernesgonzalez33 force-pushed the add-request-signature-blob branch 2 times, most recently from d84c853 to 8519fd7 Compare November 28, 2023 14:43
@ernesgonzalez33
Copy link
Contributor Author

The changes look fine to me. There are a couple of linting errors. Please review the output of the CI and fix the violations. I'll merge it when the pipeline passes.

@Allda this should be fixed! Could you please approve the checks to run?

@Allda
Copy link
Contributor

Allda commented Nov 29, 2023

The changes look fine to me. There are a couple of linting errors. Please review the output of the CI and fix the violations. I'll merge it when the pipeline passes.

@Allda this should be fixed! Could you please approve the checks to run?

There are still 2 CI errors, one is the black format (you can fix it by running tox -e black-format). And the second failure comes from unit test coverage.

@ernesgonzalez33
Add new task to request signature of blobs
d095d62 
- Add request-signature-blob task to be able of using request-signature
  to sign a blob
- Modify request-signature.py to sign container images and blobs
  depending of the arguments passed

Signed-off-by: Ernesto González <[email protected]>
@ernesgonzalez33 ernesgonzalez33 force-pushed the add-request-signature-blob branch from 8519fd7 to d095d62 Compare November 30, 2023 13:32
@ernesgonzalez33
Copy link
Contributor Author

@Allda should be solved now. I had to reorder things a bit in the function because the tests were going through a place they shouldn't have gone in the first place

@ernesgonzalez33 ernesgonzalez33 mentioned this pull request Nov 30, 2023
Merged
@Allda Allda merged commit 18d3e21 into redhat-openshift-ecosystem:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Allda Allda Allda approved these changes

@wcheang wcheang Awaiting requested review from wcheang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernesgonzalez33 @Allda