Simplify Multus install options #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
To address redhat-nfvpe#245 and redhat-nfvpe#258, this change fixes followings: + rename multus_npwg_demo to multus-2nics + make multus_use_crd default + add multus_build flag (if no/false, use daemonset yaml in github/multus) + unsupport legacy multus version + add docker_install_suppress_newgrp for latest ansible + fix daemonset yaml to support latest k8s + fix several build script (e.g. sr-iov cni) Verified it under following combinations: + pod_network_type=none + pod_network_type=multus + pod_network_type=multus + multus_build=true + pod_network_type=none + multus_build=true + pod_network_type=multus-2nics + pod_network_type=multus-2nics + multus_build=true
s1061123
force-pushed
the
dev/simplify-multus-options
branch
from
b586fa3
to
be9fabb
Compare
dougbtv
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #245 and #258, this change fixes followings:
(if no/false, use daemonset yaml in github/multus)
Verified it under following combinations: