Add basic preflight checks as the first component in the pipeline #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JudeNiroshan
force-pushed
the
preflight-checks
branch
from
19bfb68
to
d22763f
Compare
MichaelClifford
requested changes
Sep 20, 2024
Comment on lines
+15
to
+16
| if (not repo_branch) and (repo_pr is None or repo_pr <= 0 ): | ||
| raise Exception("Both taxonomy repo branch and taxonomy pull request number cannot be empty") |
There was a problem hiding this comment.
This gets checked when you try to create the run. It will give an error if you try to proceed without a PR or branch.
Failed to create a new run: Failed to generate the ExecutionSpec: invalid pipeline job inputs: Invalid input error: input parameter repo_pr requires type double or integer, but the parameter value is not of number value type
Can remove this check
| raise Exception("Model name is missing in kfp-model-server configMap") | ||
| if not endpoint: | ||
| raise Exception("Model Server endpoint URL is missing in kfp-model-server configMap") | ||
|
|
There was a problem hiding this comment.
This will fail at the first step anyways if these params are not set correctly. Do we want to add in some additional checks here that may cause failures during the training and eval steps later on as well?
|
Thanks @JudeNiroshan I made a couple of comments. Can you rebase this PR as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #19