chore(e2e): add RHDH upgrade test #2342
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
josephca
requested review from
subhashkhileri
and removed request for
albarbaro
josephca
changed the title
|
@josephca: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| echo "Deploying image from repository: ${QUAY_REPO}, TAG_NAME: ${TAG_NAME}, in NAME_SPACE: ${NAME_SPACE}" | ||
|
|
||
| helm upgrade -i "${RELEASE_NAME}" -n "${NAME_SPACE}" \ | ||
| "${HELM_REPO_NAME}/${HELM_IMAGE_NAME}" --version "${CHART_VERSION}" \ |
There was a problem hiding this comment.
@josephca if it should use latest chart version always then, we can remove "${CHART_VERSION}" so it will always point to latest version.
| echo "Deploying image from repository: ${QUAY_REPO_BASE}, TAG_NAME: ${TAG_NAME_BASE}, in NAME_SPACE: ${NAME_SPACE}" | ||
|
|
||
| helm upgrade -i "${RELEASE_NAME}" -n "${NAME_SPACE}" \ | ||
| "${HELM_REPO_NAME}/${HELM_IMAGE_NAME}" --version "${CHART_VERSION}" \ |
There was a problem hiding this comment.
| -f "${DIR}/value_files/${HELM_CHART_VALUE_FILE_NAME_BASE}" \ | ||
| --set global.clusterRouterBase="${K8S_CLUSTER_ROUTER_BASE}" \ | ||
| --set upstream.backstage.image.repository="${QUAY_REPO_BASE}" \ | ||
| --set upstream.backstage.image.tag="${TAG_NAME_BASE}" |
There was a problem hiding this comment.
@josephca this TAG_NAME_BASE will come from CI job 🤔
Description
Add RHDH upgrade test
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer