chore(e2e): add GitHub Action for building and pushing Docker images #2334
Conversation
This workflow automates building and pushing the rhdh-e2e-runner image to Quay.io upon changes to the main branch. It targets files under `.ibm/images/` and supports both amd64 and arm64 platforms. Signed-off-by: Gustavo Lira <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gustavolira
changed the title
|
The image is available at: |
Signed-off-by: Gustavo Lira <[email protected]>
| with: | ||
| context: .ibm/images/ | ||
| push: true | ||
| tags: ${{ env.REGISTRY }}/${{ env.REGISTRY_IMAGE }}:latest |
There was a problem hiding this comment.
| tags: ${{ env.REGISTRY }}/${{ env.REGISTRY_IMAGE }}:latest | |
| tags: ${{ env.REGISTRY }}/${{ env.REGISTRY_IMAGE }}:next |
I still think we should align the tag naming with the nightly builds of RHDH or with branch names.
So either use next or main here.
There was a problem hiding this comment.
| tags: ${{ env.REGISTRY }}/${{ env.REGISTRY_IMAGE }}:latest | |
| tags: ${{ env.REGISTRY }}/${{ env.REGISTRY_IMAGE }}:${{ github.ref_name }} |
tag based on branch name
There was a problem hiding this comment.
@zdrapela I can handle it on a specific PR
There was a problem hiding this comment.
Suggestion from @subhashkhileri would work perfectly here. Why not incorporate it now 🤔
|
|
||
| concurrency: | ||
| group: post-merge-build | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
@gustavolira cancel true makes sense, so that only the latest gets build and pushed
| with: | ||
| context: .ibm/images/ | ||
| push: true | ||
| tags: ${{ env.REGISTRY }}/${{ env.REGISTRY_IMAGE }}:latest |
There was a problem hiding this comment.
@gustavolira can we make this tag dynamic based on branch name? like for main latest and release 1.4 it will be ${{ env.REGISTRY }}/${{ env.REGISTRY_IMAGE }}:release-1.4 or simply 1.4
There was a problem hiding this comment.
so same job will build different images for different releases and we can simply reference them in our job
There was a problem hiding this comment.
I would align with the RHDH nightly builds as @nickboldt suggested: openshift/release#61263 (comment)
There was a problem hiding this comment.
Yes, using branch name as tag is less confusing.
|
The image is available at: |
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
add release 1.3 and 1.4 as well for branch specific tags
This workflow automates building and pushing the rhdh-e2e-runner image to Quay.io upon changes to the main branch. It targets files under
.ibm/images/and supports both amd64 and arm64 platforms.Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer