Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): incorporate tls tests into showcase-runtime #2271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Omar-AlJaljuli
Copy link
Contributor

Description

Right now there is one TLS config test that runs as it's own test suite. Later on more TLS config tests will be made, so they need to all be contained into one test suite in one namespace (showcase-runtime).

Which issue(s) does this PR fix

RHIDP-5557

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Jan 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign psrna for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

1 similar comment
@Omar-AlJaljuli
Copy link
Contributor Author

/test all

@Omar-AlJaljuli Omar-AlJaljuli force-pushed the incorporate-tls-into-runtime branch from f63b6bd to bac32ff Compare January 28, 2025 19:54
@Omar-AlJaljuli
Copy link
Contributor Author

/test all

1 similar comment
@Omar-AlJaljuli
Copy link
Contributor Author

/test all

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Omar-AlJaljuli Omar-AlJaljuli force-pushed the incorporate-tls-into-runtime branch from 1a53e71 to 029f99a Compare January 28, 2025 23:22
@Omar-AlJaljuli Omar-AlJaljuli marked this pull request as ready for review January 28, 2025 23:24
@openshift-ci openshift-ci bot requested a review from nilgaar January 28, 2025 23:24
@subhashkhileri
Copy link
Member

/test periodic-e2e-tests

Copy link

openshift-ci bot commented Jan 29, 2025

@Omar-AlJaljuli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/periodic-e2e-tests 029f99a link false /test periodic-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants