Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: misc wrapper fixes #2268

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore: misc wrapper fixes #2268

merged 1 commit into from
Jan 30, 2025

Conversation

04kash
Copy link
Collaborator

@04kash 04kash commented Jan 28, 2025

Description

  • Added missing turbo.json file to red-hat-developer-hub-backstage-plugin-global-header
  • Updated supported version to 1.35.0 in red-hat-developer-hub-backstage-plugin-marketplace-backend-dynamic

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@04kash 04kash force-pushed the misc-fixes branch 2 times, most recently from 72d46af to 04724c0 Compare January 28, 2025 17:08
Copy link
Contributor

Signed-off-by: Kashish Mittal <[email protected]>
Copy link
Contributor

@04kash
Copy link
Collaborator Author

04kash commented Jan 30, 2025

/retest

2 similar comments
@04kash
Copy link
Collaborator Author

04kash commented Jan 30, 2025

/retest

@04kash
Copy link
Collaborator Author

04kash commented Jan 30, 2025

/retest

@04kash 04kash requested review from nickboldt, schultzp2020 and BethGriggs and removed request for dzemanov and its-mitesh-kumar January 30, 2025 20:20
Copy link
Collaborator

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 92f21d8 into main Jan 30, 2025
13 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the misc-fixes branch January 30, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants