Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): fix a module which has no default export #2250

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

josephca
Copy link
Contributor

Description

When running e2e test in local environment, it fails with the error:
SyntaxError: The requested module '@kubernetes/client-node' does not provide an export named 'default'

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@gustavolira
Copy link
Contributor

/test e2e-tests

@gustavolira
Copy link
Contributor

/retest-required

1 similar comment
@gustavolira
Copy link
Contributor

/retest-required

@gustavolira
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Jan 27, 2025
@gustavolira
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2025
@josephca
Copy link
Contributor Author

/retest-required

1 similar comment
@josephca
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot removed the lgtm label Jan 28, 2025
@gustavolira
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 28, 2025
@openshift-ci openshift-ci bot removed the lgtm label Jan 29, 2025
@gustavolira
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 29, 2025
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 20234e4 into redhat-developer:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants