Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update opentelemetry/host-metrics to fix CVE-2024-56334 #2186

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

kim-tsao
Copy link
Member

Description

Please explain the changes you made here.

  • patch update for @opentelemetry/host-metrics which contains a fix version for the systeminformation dependency
  • seems to be a safe update since changes have been minimal since 0.35.4

Which issue(s) does this PR fix

  • Fixes #?

CVE-2024-56334
https://issues.redhat.com/browse/RHIDP-5541

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@kim-tsao kim-tsao requested review from coreydaley and JessicaJHee and removed request for divyanshiGupta and dzemanov January 14, 2025 19:39
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JessicaJHee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@kim-tsao
Copy link
Member Author

/test e2e-tests

1 similar comment
@kim-tsao
Copy link
Member Author

/test e2e-tests

Copy link

openshift-ci bot commented Jan 15, 2025

@kim-tsao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 6bcd48a link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kim-tsao kim-tsao merged commit 011f17d into redhat-developer:release-1.4 Jan 15, 2025
7 of 10 checks passed
Copy link
Contributor

@kim-tsao
Copy link
Member Author

/cherrypick main

@openshift-cherrypick-robot
Copy link
Contributor

@kim-tsao: #2186 failed to apply on top of branch "main":

Applying: chore: update opentelemetry/host-metrics to fix CVE-2024-56334
Using index info to reconstruct a base tree...
M	packages/backend/package.json
M	yarn.lock
Falling back to patching base and 3-way merge...
Auto-merging yarn.lock
CONFLICT (content): Merge conflict in yarn.lock
Auto-merging packages/backend/package.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 chore: update opentelemetry/host-metrics to fix CVE-2024-56334

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants