chore(migration): refactor hardcoded repo and images (#2172, #2181) #2174
Conversation
|
Latest images are at https://quay.io/repository/rhdh-community/rhdh?tab=tags&tag=latest instead of in the janus-idp/backstage-showcase quay location. Please update accordingly. |
|
re: the failure of the PR Build Image test This is hopefully caused by the migration from janus-idp to redhat-developer in RHIDP-1022. I'll look into why this works in main but not in release-1.4 today. |
|
New changes are detected. LGTM label has been removed. |
zdrapela
changed the title
zdrapela
changed the title
|
The image is available at: |
| @@ -205,7 +205,7 @@ upstream: | |||
| - name: install-dynamic-plugins | |||
| # -- Image used by the initContainer to install dynamic plugins into the `dynamic-plugins-root` volume mount. | |||
| # It could be replaced by a custom image based on this one. | |||
| # @default -- `quay.io/janus-idp/backstage-showcase:latest` | |||
| # @default -- `quay.io/rhdh-community/rhdh:latest` | |||
There was a problem hiding this comment.
There is no :latest tag, only :next
| # @default -- `quay.io/rhdh-community/rhdh:latest` | |
| # @default -- `quay.io/rhdh-community/rhdh:next` |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josephca, nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Refactor repo name and image.
janus-idp/backstage-showcase=>redhat-developer/rhdhjanus-idp/backstage-showcase=>rhdh-community/rhdhThis fixes this error caused by having hardcoded variables and the repo migration:
Should fix also:
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer