Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): improvements & fix for Data Router #2157

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented Jan 8, 2025

Description

Apply recent Data Router improvements & fixes from main.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@zdrapela zdrapela requested a review from a team as a code owner January 8, 2025 11:09
@openshift-ci openshift-ci bot requested review from josephca and rnapoles-rh January 8, 2025 11:09
@zdrapela zdrapela changed the title chore(ci): Data Router improvements & fix chore(ci): improvements & fix for Data Router Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2157!

@zdrapela zdrapela force-pushed the cherry-pick-droute-fix-1.3 branch from 146796b to 9e8bf10 Compare January 8, 2025 12:47
Copy link
Contributor

github-actions bot commented Jan 8, 2025

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2157!

Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link
Contributor

github-actions bot commented Jan 8, 2025

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2157!

@nilgaar
Copy link
Contributor

nilgaar commented Jan 8, 2025

/lgtm

@zdrapela
Copy link
Member Author

zdrapela commented Jan 8, 2025

@josephca Please approve (only you are in the OWNERS file for 1.3).

Copy link
Contributor

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca, nilgaar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c0f032c into redhat-developer:release-1.3 Jan 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants