Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): disable exit on error in droute send for PR checks #2125

Conversation

subhashkhileri
Copy link
Contributor

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@subhashkhileri subhashkhileri requested a review from a team as a code owner December 19, 2024 11:08
@subhashkhileri subhashkhileri changed the title chore(ci): disable exit on error in droute send chore(ci): disable exit on error in droute send for PR checks Dec 19, 2024
@openshift-ci openshift-ci bot removed the lgtm label Dec 19, 2024
@kadel
Copy link
Member

kadel commented Dec 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadel kadel mentioned this pull request Dec 19, 2024
5 tasks
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2125!

@openshift-merge-bot openshift-merge-bot bot merged commit 8953435 into redhat-developer:release-1.3 Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants