Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update OpenTelemetry set up documentation #1954

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

JessicaJHee
Copy link
Contributor

Description

Updates the metrics set up documentation to reflect the new behaviour after adopting OpenTelemetry in this PR

Which issue(s) does this PR fix

RHIDP-4404

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

Copy link

openshift-ci bot commented Nov 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JessicaJHee JessicaJHee changed the title update OpenTelemetry set up documentation docs: update OpenTelemetry set up documentation Nov 19, 2024
@JessicaJHee
Copy link
Contributor Author

JessicaJHee commented Nov 20, 2024

waiting for this PR to be accepted [Done]

@JessicaJHee JessicaJHee marked this pull request as ready for review November 20, 2024 20:50
@JessicaJHee JessicaJHee requested a review from a team as a code owner November 20, 2024 20:50
@JessicaJHee JessicaJHee marked this pull request as draft November 20, 2024 20:52
@JessicaJHee JessicaJHee marked this pull request as ready for review November 20, 2024 20:54
@openshift-ci openshift-ci bot requested a review from dzemanov November 20, 2024 20:54
@kim-tsao
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot removed the lgtm label Nov 27, 2024
@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2024
Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao
Copy link
Member

I'm going to force merge this as it's just a docs update

@kim-tsao kim-tsao merged commit b492fb6 into redhat-developer:main Nov 27, 2024
7 of 8 checks passed
@kim-tsao
Copy link
Member

/cherrypick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@kim-tsao: new pull request created: #1998

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

teknaS47 pushed a commit to teknaS47/backstage-showcase that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants