Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing sonar on enforce names #1922

Closed
wants to merge 10 commits into from
Closed

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Nov 13, 2024

Description

#1906

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

wip

wip

replace old references with rbacPo
Copy link

openshift-ci bot commented Nov 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nilgaar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fixing sonar on enforce names". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - chore
 - docs
 - style
 - refactor
 - perf
 - test
 - revert

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 13, 2024

/test all

Copy link
Contributor

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 13, 2024

/test all

Copy link
Contributor

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 14, 2024

/test all

Copy link
Contributor

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 14, 2024

/test all

Copy link
Contributor

Copy link

openshift-ci bot commented Nov 14, 2024

@nilgaar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests b57e8e2 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 14, 2024

/test all

Copy link
Contributor

Copy link
Contributor

@nilgaar nilgaar closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants