Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): dedupe @types/http-proxy #1891

Merged

Conversation

kim-tsao
Copy link
Member

@kim-tsao kim-tsao commented Nov 6, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?
  • related to e0166d5 which dedupes the dependency.

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@kim-tsao kim-tsao requested a review from a team as a code owner November 6, 2024 04:12
Copy link

sonarqubecloud bot commented Nov 6, 2024

Copy link
Contributor

github-actions bot commented Nov 6, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1891!

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
@nickboldt nickboldt merged commit 63c54ea into redhat-developer:release-1.3 Nov 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants