feat(marketplace): Refactore and update UI, add filter and align it latest design and API changes #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
christoph-jerolimov
force-pushed
the
marketplace-ui
branch
3 times, most recently
from
ec9f85b to
13b470f
Compare
| 'apiVersion' in maybe && | ||
| 'kind' in maybe && | ||
| maybe.apiVersion === 'marketplace.backstage.io/v1alpha1' && | ||
| maybe.kind === 'Plugin' |
There was a problem hiding this comment.
nit:
Suggested change
| maybe.kind === 'Plugin' | |
| maybe.kind === MarketplaceKind.Plugin |
| @@ -187,7 +187,7 @@ describe('createRouter', () => { | |||
| const { backendServer } = await setupTestWithMockCatalog({ | |||
| mockData: mockPluginList[0], | |||
| name: 'featured-plugins', | |||
| kind: 'pluginlist', | |||
| kind: 'PluginList', | |||
There was a problem hiding this comment.
nit:
Suggested change
| kind: 'PluginList', | |
| kind: MarketplaceKind.PluginList, |
Comment on lines
+72
to
+77
| return { | ||
| color: colors.custom, | ||
| label: 'Custom', | ||
| tooltip: 'Custom', | ||
| }; | ||
| }; |
There was a problem hiding this comment.
This shows Custom badge by default for all the entities missing certified/verified annotations, is this expected?
There was a problem hiding this comment.
Oh I see this in figma, label reads Custom plugins there.
|
|
||
| const SupportTypeFilter = () => { | ||
| const categoriesFacet = usePluginFacet('spec.categories'); | ||
| const categories = categoriesFacet.data?.facets['spec.categories']; |
There was a problem hiding this comment.
Instead of categories, Shouldn't this be Certified, Verified, and Custom ?
| export const MarketplacePluginsGrid = () => { | ||
| const pluginLists = usePluginLists(); | ||
|
|
||
| const [search] = useQueryParamState<string | undefined>('q'); |
There was a problem hiding this comment.
looks like you need to also add the filters for category, author and support.type here, or is it coming in next pr?
5 tasks
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
…ketplace into the existing plugins page Signed-off-by: Christoph Jerolimov <[email protected]>
christoph-jerolimov
force-pushed
the
marketplace-ui
branch
from
d4391e3 to
f8cd5e7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Address:
✔️ Checklist