fix(orchestrator):implement filters #386
Conversation
Signed-off-by: Lior Soffer <[email protected]>
LiorSoffer
requested review from
batzionb,
mareklibra and
gciavarrini
as code owners
Changed Packages
|
|
| const currentDate = new Date(); | ||
| const endOfToday = new Date(currentDate); | ||
| endOfToday.setHours(23, 59, 59, 999); | ||
|
|
There was a problem hiding this comment.
If I'm not wrong, new Date() uses the tz in which the system is running. Can you please double check if it's ok?
what if the user tz is different from system tz?
| } | ||
| return undefined; | ||
| }, [statusSelectorValue, workflowId]); | ||
| return filters[0] || undefined; |
There was a problem hiding this comment.
why filters[0]? can't be there more than one valid filter?
There was a problem hiding this comment.
This looks good to me since if (filters.length > 1) above handles that case
| <Selector | ||
| label="Status" | ||
| items={statuses} | ||
| onChange={value_ => { |
There was a problem hiding this comment.
| onChange={value_ => { | |
| onChange={value => { |
| <Selector | ||
| label="Started" | ||
| items={started} | ||
| onChange={value_ => { |
There was a problem hiding this comment.
Likewise. Please check other occurrences of this pattern as well.
| } | ||
| return undefined; | ||
| }, [statusSelectorValue, workflowId]); | ||
| return filters[0] || undefined; |
There was a problem hiding this comment.
This looks good to me since if (filters.length > 1) above handles that case
resolve FLPATH-1989
Screencast.from.2025-02-04.19-10-12.mp4