fix: RHDHBUGS-98: Update audit log persistent volume mount path #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreydaley
force-pushed
the
coreydaley-patch-2
branch
from
f40c7ad
to
63c394f
Compare
Update the audit log persistent volume mount path to be consistent with the path that the audit logs are being written to by default https://github.com/janus-idp/backstage-showcase/blob/main/packages/backend/src/logger/customLogger.ts#L68-L70 Update the default configuration to write the audit log to the pvc Signed-off-by: Corey Daley <[email protected]>
coreydaley
force-pushed
the
coreydaley-patch-2
branch
from
63c394f
to
6784ddd
Compare
|
coreydaley
changed the title
|
/assign @kim-tsao @gazarenkov @rm3l |
rm3l
reviewed
Oct 17, 2024
2 tasks
nickboldt
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the audit log persistent volume mount path to be consistent with the path that the audit logs are being written to by default https://github.com/janus-idp/backstage-showcase/blob/main/packages/backend/src/logger/customLogger.ts#L68-L70
I have manually tested this via Clean Install and Upgrade from previous non-working Helm Install and both showed the correct behavior without any upgrade errors.
Description of the change
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.