-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to ESModule #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: did you try to load the extension ?
I think changing the type produces a different file or the way we do imports etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffmaury @benoitf do you think you could provide some steps to build the image and load it to PD? |
Signed-off-by: Rostislav Lán <[email protected]>
I just build the image of the extension using the provided Containerfile, pushed it to quay.io and then loaded it as a custom extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Switching to ES modules by setting
"type": "module"
in package.json in order to use e2e tests core (@podman-desktop/tests/playwright). Also added settings for modules to tsconfig.json file.