Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ESModule #65

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Switch to ESModule #65

merged 1 commit into from
Feb 25, 2025

Conversation

rostalan
Copy link
Contributor

@rostalan rostalan commented Feb 18, 2025

Switching to ES modules by setting "type": "module" in package.json in order to use e2e tests core (@podman-desktop/tests/playwright). Also added settings for modules to tsconfig.json file.

@rostalan rostalan requested a review from a team as a code owner February 18, 2025 10:23
Copy link

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: did you try to load the extension ?

I think changing the type produces a different file or the way we do imports etc

Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I build the image and try to install from it, I have the following error:

image

@rostalan
Copy link
Contributor Author

@jeffmaury @benoitf do you think you could provide some steps to build the image and load it to PD?
I tried to fix the error, but I don't know how to verify it works.

Signed-off-by: Rostislav Lán <[email protected]>
@jeffmaury
Copy link
Member

@jeffmaury @benoitf do you think you could provide some steps to build the image and load it to PD? I tried to fix the error, but I don't know how to verify it works.

I just build the image of the extension using the provided Containerfile, pushed it to quay.io and then loaded it as a custom extension

@rostalan
Copy link
Contributor Author

Ok, the fix seems to work, after building the image and loading it in PD on windows, it shows no errors and upon inspection, correctly insects images.
image

@rostalan rostalan requested a review from jeffmaury February 25, 2025 09:18
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rostalan rostalan merged commit a66e031 into redhat-developer:main Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants