-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: podman desktop extension #34
Conversation
Not sure if this is expected bc i have to do something or there is an error, so asking |
Which OS/arch are you using? |
windows amd64 |
Which version of Podman desktop are you using? Particularly, does it include this patch? podman-desktop/podman-desktop#5069 |
i was using my local main branch but probably it was not rebased, let me re-try |
Ok it was a problem with my branch. Works fine, thanks @feloy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e129447
to
38bf64b
Compare
222aa83
to
38bf64b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dependencies": {}, | ||
"devDependencies": { | ||
"@podman-desktop/api": "next", | ||
"@types/node": "^20.9.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in phase with the node version use so ^18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you trying to run by moving the sources into the podman desktop sources and building it as the same time as PD?
Or by downloading an image from the Extensions page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using with different code bases but from the Podman Dekstop one, I'm running yarn watch --extension-folder ../../redhat-developer/podman-desktop-image-checker-openshift-ext/podman-desktop-extension/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I didn't understand it was expected to be ran this way also.
I think I'll have to adapt the tsconfig.json file to make it compatible for both this way and built as an independent module into an image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I've made a fix to make it buildable with yarn watch
and inside an image.
But with yarn watch
, you still won't have the doa
executable built, and it won't be found by the extension. Do we want to automate this in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to build the image, I have a warning that yarn build but there is no lock file
Also would be good to add node_modules to .gitignore
It should be fixed with the latest commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
An image can be created and pushed with
./scripts/build.sh <image-name> <tag>
This creates a multi-platform image for (windows,linux,darwin) x (amd64,arm64).
Fixes #21