Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options #18

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Fix options #18

merged 3 commits into from
Nov 15, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 20, 2023

Options with single letter and double dash (--f, --i, --o) are not common. This PR changes to have a long name (file, image, output) with double dash and single letter with single-dash:

./bin/doa analyze --help
Analyze the Dockerfile and discover potential issues when deploying it on OpenShift. It accepts the project root path or the Dockerfile path.

Usage:
  doa analyze [flags]

Examples:
  doa analyze -f /your/local/project/path[/Dockerfile_name]

Flags:
  -f, --file string     Container file to analyze
  -h, --help            help for analyze
  -i, --image string    Image name to analyze
  -o, --output string   Specify output format, supported format: json
  • Small fix on doc with wrong expose port

@jeffmaury
Copy link
Member

@feloy please rebase

Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feloy feloy merged commit 3c27c43 into redhat-developer:main Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants