fix: process FROM scratch (#25)

* fix: process FROM scratch Fixes #24 Signed-off-by: Jeff MAURY <[email protected]>
redhat-developer · Nov 17, 2023 · 04cfc71 · 04cfc71
1 parent 6448cfa
commit 04cfc71
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/pkg/command/analyzer_test.go b/pkg/command/analyzer_test.go
@@ -19,3 +19,10 @@ func TestCheckNginx(t *testing.T) {
 		})
 	}
 }
+
+func TestFromScratch(t *testing.T) {
+	errors := AnalyzePath("resources/Containerfile.fromscratch")
+	if len(errors) > 0 {
+		t.Error("Image with FROM scratch returns errors")
+	}
+}
diff --git a/pkg/command/from.go b/pkg/command/from.go
@@ -12,7 +12,6 @@ package command
 
 import (
 	"fmt"
-
 	"github.com/moby/buildkit/frontend/dockerfile/parser"
 	"github.com/redhat-developer/docker-openshift-analyzer/pkg/decompiler"
 	"github.com/redhat-developer/docker-openshift-analyzer/pkg/utils"
@@ -21,7 +20,12 @@ import (
 type From struct {
 }
 
+const SCRATCH_IMAGE_NAME = "scratch"
+
 func (f From) Analyze(node *parser.Node, source utils.Source, line Line) []error {
+	if node.Value == SCRATCH_IMAGE_NAME {
+		return nil
+	}
 	errs := []error{}
 	decompiledNode, err := decompiler.Decompile(node.Value)
 	if err != nil {

diff --git a/pkg/command/resources/Containerfile.fromscratch b/pkg/command/resources/Containerfile.fromscratch
@@ -0,0 +1 @@
+FROM scratch