Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include a demo extension #27

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 4, 2023

allow to setup the podify containers using Podman Desktop

Screen.Recording.2023-10-04.at.10.59.25.mov

you can try with extension quay.io/podman-desktop-demo/podman-desktop-extension (using current main branch of Podman Desktop)

allow to setup the podify containers using Podman Desktop
@benoitf
Copy link
Collaborator Author

benoitf commented Oct 4, 2023

@slemeur I think you need the main branch (not 1.4.0 or an old 1.5.0-next version)

Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed the extension on the latest Podman Desktop build, created a new machine to be safe, and clicked the button. Received two errors:

  • Images preloaded failedError: no running provider for the matching container
  • Backend image not found. Cannot run containers
    so nothing happened, but the icon changed? 🤷🏻‍♂️

Took me a minute to realize that (obviously) I needed to re-install the demo content since I had a new Podman machine, and about the same time I found the tooltip: Please run the preload command.

Ran init.sh and saw the images appear. Tried again, and it still failed. Restarted Podman Desktop and tried a third time, this time everything worked great. 👍🏼

I am approving anyway, since I think getting this initial extension and build process in is way more important than some usability issues; once you've used it once it is straightforward enough, and we can iterate.

Maybe the one change I'd make is changing the tooltip to Please run the init.sh/bat command?

@benoitf
Copy link
Collaborator Author

benoitf commented Oct 5, 2023

AFAIK you shouldn't need to run any .sh scripts with this extension, only one click so I'm interested to know why it failed. I'll investigate

@deboer-tim
Copy link
Collaborator

Ah. Yeah, I didn't realize it had the command to pull the images first. Looks like it hit a case in container-registry.ts where provider.api is undefined? My pulling images might have been completely coincidental then. Either way it worked after restart/wasn't blocking so I am fine working this out later.

@deboer-tim
Copy link
Collaborator

Had to delete all my podman machines to test a PR, so I created a new one and tried this again. It failed b/c Quay is down atm :( , but noticed again that podman-desktop-demo.ts:312 should exit if the pull command failed so that you don't get two error dialogs. This is easy enough to fix later though, so I am still good to merge.

@benoitf
Copy link
Collaborator Author

benoitf commented Oct 18, 2023

ok merging and let's file issue to fix problems

@benoitf benoitf merged commit 3914f34 into redhat-developer:main Oct 18, 2023
1 check passed
@deboer-tim
Copy link
Collaborator

Updated issue #29 with what I think were all the problems I noticed. It should be broken up a bit, but at least it is tracked for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants