Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README main title and display preview video #7037

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Aug 22, 2023

What type of PR is this:
/area documentation

What does this PR do / why we need it:
This is an addendum to #6862, to be consistent with the main title on https://odo.dev/ and the project description.

Which issue(s) this PR fixes:
Fixes #6794

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Preview: https://github.com/rm3l/odo/blob/6794-mention-podman-support-on-website--addendum/README.md

Headings should suffice.
This way, users can have a chance to have a quick preview of odo.
@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Aug 22, 2023
@openshift-ci openshift-ci bot requested review from feloy and kadel August 22, 2023 09:56
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c03b478
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64e486556948bb00080952e1

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Aug 22, 2023

Kubernetes Docs Tests on commit edf0bf3 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 22, 2023
@rm3l
Copy link
Member Author

rm3l commented Aug 22, 2023

INFO[2023-08-22T10:26:50Z] build didn't start running within 30m0s (phase: Pending):
Found 1 events for Pod root-build:
* 2023-08-22T10:21:54Z 127x default-scheduler: 0/18 nodes are available: 1 Insufficient cpu, 1 node(s) didn't match Pod's node affinity/selector, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-longtests-worker: ci-longtests-worker}, 2 node(s) had untolerated taint {node-role.kubernetes.io/infra: }, 3 node(s) had untolerated taint {node-role.kubernetes.io/ci-prowjobs-worker: ci-prowjobs-worker}, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }, 7 node(s) had untolerated taint {node-role.kubernetes.io/ci-tests-worker: ci-tests-worker}. preemption: 0/18 nodes are available: 1 No preemption victims found for incoming pod, [17](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-developer_odo/7037/pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images/1693925142243053568#1:build-log.txt%3A17) Preemption is not helpful for scheduling.. 
INFO[2023-08-22T10:26:50Z] Ran for 30m0s

/override ci/prow/odo-ocp4.13-lp-interop-images
/override ci/prow/odo-ocp4.14-lp-interop-images
/override ci/prow/v4.13-images

Not relevant for this PR.

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/odo-ocp4.13-lp-interop-images, ci/prow/odo-ocp4.14-lp-interop-images, ci/prow/v4.13-images

In response to this:

INFO[2023-08-22T10:26:50Z] build didn't start running within 30m0s (phase: Pending):
Found 1 events for Pod root-build:
* 2023-08-22T10:21:54Z 127x default-scheduler: 0/18 nodes are available: 1 Insufficient cpu, 1 node(s) didn't match Pod's node affinity/selector, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-longtests-worker: ci-longtests-worker}, 2 node(s) had untolerated taint {node-role.kubernetes.io/infra: }, 3 node(s) had untolerated taint {node-role.kubernetes.io/ci-prowjobs-worker: ci-prowjobs-worker}, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }, 7 node(s) had untolerated taint {node-role.kubernetes.io/ci-tests-worker: ci-tests-worker}. preemption: 0/18 nodes are available: 1 No preemption victims found for incoming pod, [17](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-developer_odo/7037/pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images/1693925142243053568#1:build-log.txt%3A17) Preemption is not helpful for scheduling.. 
INFO[2023-08-22T10:26:50Z] Ran for 30m0s

/override ci/prow/odo-ocp4.13-lp-interop-images
/override ci/prow/odo-ocp4.14-lp-interop-images
/override ci/prow/v4.13-images

Not relevant for this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b471f4b into redhat-developer:main Aug 22, 2023
3 checks passed
@rm3l rm3l deleted the 6794-mention-podman-support-on-website--addendum branch August 22, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention Podman support on website
3 participants