Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin 3rd-party actions to SHA1 #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fbricon
Copy link

@fbricon fbricon commented Feb 17, 2023

Hi!

Following the GH Action Security Hardening guide we should use the commit SHA instead of the branch or tag for any third-party untrusted action.

This PR was submitted by a script.

@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbose78 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 22, 2024

@fbricon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.10-e2e f3749d6 link true /test v4.10-e2e
ci/prow/v4.11-e2e f3749d6 link true /test v4.11-e2e
ci/prow/v4.8-e2e f3749d6 link true /test v4.8-e2e
ci/prow/v4.9-e2e f3749d6 link true /test v4.9-e2e
ci/prow/v4.12-e2e f3749d6 link true /test v4.12-e2e
ci/prow/v4.13-images f3749d6 link true /test v4.13-images
ci/prow/v4.13-e2e f3749d6 link true /test v4.13-e2e
ci/prow/v4.12-images f3749d6 link true /test v4.12-images
ci/prow/v4.14-e2e f3749d6 link true /test v4.14-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant