Make sonar plugin installer more idempotent

roles/add-sonar-plugin/README.md

@@ -20,4 +20,6 @@ This role uses the OpenShift command-line tool to upload a JAR based SonarQube p
 # Testing
 * Deploy a [Labs CI/CD environment](https://github.com/rht-labs/labs-ci-cd)
 * Apply the role using the test playbook: `ansible-playbook -i inventory test.yml
-* Verify deployment after SonarQube restarts
+* Verify deployment after SonarQube restarts
+* Apply the inventory a second time and ensure that SonarQube continues to start
+  * Multiple instances of the same plugin will cause SonarQube to fail on startup

roles/add-sonar-plugin/tasks/main.yml

@@ -3,27 +3,46 @@
 - name: Get JAR name
   set_fact:
     jar_name: "{{ plugin_url.split('/')[-1] }}"
-
-- name: Download the SonarQube plugin
-  get_url:
-    url: "{{ plugin_url }}"
-    dest: "/tmp/{{ jar_name }}"
-    mode: 0440
+    plugin_name: "{{ plugin_url.split('/')[-1] | regex_replace('-([0-9]+\\.?)+\\.jar', '') }}"
 
 ## The Jinja2 template and the Go template in the following task conflict,
 ## so the weird double-curly-braces surrounded by double-curly-braces is required.
 - name: Find sonarqube pod
   command: >-
-      oc get pods --namespace={{ namespace }} -l="app==sonarqube"
+      oc get pods --namespace={{ namespace }} -l='app==sonarqube'
       -o jsonpath="{.items[0].metadata.name}"
-  register: pod_name_lines
+  register: pod_name
 
 - name: Extract pod name
   set_fact:
-    pod_name: "{{ pod_name_lines.stdout }}"
+    pod_name: "{{ pod_name.stdout }}"
+
+- name: Check for existing plugin install_location
+  command: >-
+    oc exec -i --namespace={{ namespace }} {{ pod_name }} -- find {{ install_location }}/ -type f -name '{{ plugin_name }}*jar'
+  register: existing_plugin
+
+- name: Create tempfile for sonar plugin list
+  tempfile:
+    state: file
+    suffix: temp
+  register: plugin_list_tempfile
+
+- name: Download the SonarQube plugin
+  get_url:
+    url: "{{ plugin_url }}"
+    dest: "{{ plugin_list_tempfile }}"
+  when: existing_plugin is not defined or not existing_plugin.stdout.endswith(jar_name)
+
+- name: Delete any existing matching plugins
+  command: >-
+    oc exec --namespace={{ namespace }} {{ pod_name }} -- find {{ install_location }}/ -type f -name '{{ plugin_name }}*jar' -delete
+  when: existing_plugin is defined and not existing_plugin.stdout.endswith(jar_name)
 
 - name: Copy plugin to SonarQube pod
   command: "oc cp /tmp/{{ jar_name }} {{ namespace }}/{{ pod_name }}:{{ install_location }}/{{ jar_name }}"
+  when: existing_plugin is not defined or not existing_plugin.stdout.endswith(jar_name)
 
 - name: Redeploy SonarQube
-  command: "oc rollout latest --namespace={{ namespace }} {{ pod_prefix }}"
+  command: "oc rollout latest --namespace={{ namespace }} {{ pod_prefix }}"
+  when: existing_plugin is not defined or not existing_plugin.stdout.endswith(jar_name)

roles/add-sonar-plugin/tests/test.yml

@@ -6,5 +6,5 @@
     vars:
       plugin_url: https://github.com/SonarOpenCommunity/sonar-cxx/releases/download/cxx-1.2.2/sonar-cxx-plugin-1.2.2.1653.jar
       install_location: /opt/sonarqube/extensions/plugins
-      namespace: deven-role-test
-      pod_prefix: sonarqube
+      namespace: test-ci-cd
+      pod_prefix: sonarqube