Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing remaining Charts #555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tjungbauer
Copy link
Contributor

What is this PR About?

Added remaining Charts from charts.stderr.at
compliance-operator-full-stack
cost-management
cyclonedx
file-integrity-operator
generic-cluster-config
helm-policy-generator
helper-argocd
helper-loki-bucket-secret
helper-lokistack
helper-objectstore
helper-operator
helper-proj-onboarding
elper-status-checker
minio-configurator
openshift-data-foundation
openshift-gitops
openshift-logging
rhacm-setup
rhacs-setup
setup-container-security-operator

How do we test this?

each chart has a detailed README.md that should explain all possible settings and options

cc: @redhat-cop/day-in-the-life

@ckavili
Copy link
Contributor

ckavili commented Jul 16, 2024

thanks for this giant PR @tjungbauer :D There are some overlapping charts like gitops/argocd with gitops-operator, proj-onboarding with bootstrap-project, generic cluster config with helper-operator. These are the ones I could see at least. I'd rather improve the existing ones instead of duplicating them 👀

wdyt @eformat @springdo? appreciate your comments on this giant PR 😅

@eformat
Copy link
Contributor

eformat commented Jul 18, 2024

hmm .. its a big PR. seems these are all using the operator helper chart to install operators

e.g. the openshift-gitops in the PR is not at all the same as what the current Chart does.

image

so the naming clashes will need resolving. they are not doing the same thing.

perhaps all the ones that are just installing operators should be prefixed with "install-operator-name" ?

or similar.

@tjungbauer
Copy link
Contributor Author

tjungbauer commented Jul 18, 2024

Hi,

Maybe I should elaborate on the charts a little bit :)
So all of these charts are used to fully configure a cluster. they are used from here: https://github.com/tjungbauer/openshift-clusterconfig-gitops

The idea is to have simple and a full template charts that can be used as a dependency to avoid code repetition, thus the army of helper-charts.
The helper-operator (and helper-status-checker) are the main charts to deploy an operator. but they are usually not used standalone. here is a very simple example of cert-manager: https://blog.stderr.at/gitopscollection/2024-07-04-managing-certificates-with-gitops/ It does not just install the operator, it installs it, verified if the Operator is ready and then configures it. All in the same Argo CD Application. I tried to explain the reason for the operators here: https://blog.stderr.at/openshift/2023/03/operator-installation-with-argo-cd/

The helper-proj-onboarding chart is the base of: https://www.redhat.com/en/blog/project-onboarding-using-gitops-and-helm?channel=/en/blog/channel/hybrid-cloud-infrastructure
It allows configuration of quota based on t-shirt sizes, netpols, Argo CD rbac etc.

PS: The origin of the charts is here: https://charts.stderr.at/ thats the "upstream" :)
I was asked to merge them into a more prominent space

@tjungbauer
Copy link
Contributor Author

Hi, Do you have any specific questions to the charts? Or shall we lint and can then be merged?

br
thomas

@eformat
Copy link
Contributor

eformat commented Aug 6, 2024

hi @tjungbauer - i think the names that clash with existing charts will need resolving as a first step.

@tjungbauer
Copy link
Contributor Author

Hi, I am not 100% sure which names are clashing? the only names that should exist are the ones you merged in an earlier PR. this is an update for them plus a lot of new charts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants