Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned up jenkins agents to use common base image #683

Merged
merged 3 commits into from
Dec 18, 2023
Merged

cleaned up jenkins agents to use common base image #683

merged 3 commits into from
Dec 18, 2023

Conversation

garethahealy
Copy link
Contributor

  • added hadolint to lint dockerfiles
  • added multi stage builds, so any tars are pre-downloaded and only required bits are copied into runnable image
  • updated to use common base agent

cc: @redhat-cop/day-in-the-life

@garethahealy garethahealy requested a review from a team as a code owner December 18, 2023 12:41
@garethahealy garethahealy mentioned this pull request Dec 18, 2023
Closed
@garethahealy
Copy link
Contributor Author

good to merge

pabrahamsson
pabrahamsson approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing this

@pabrahamsson pabrahamsson merged commit b65ea74 into redhat-cop:main Dec 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabrahamsson pabrahamsson pabrahamsson approved these changes

Assignees

@pabrahamsson pabrahamsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garethahealy @pabrahamsson