Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-platform-controller update #5253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

multi-platform-controller update #5253

wants to merge 1 commit into from
+4 −4

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Jan 12, 2025 •
edited
Loading

@openshift-ci openshift-ci bot requested review from hugares and ifireball January 12, 2025 09:19
ifireball
ifireball approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 12, 2025 •
edited
Loading

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-upgrade-tests 509aa00 link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mshaposhnik
Copy link
Contributor

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ifireball, mshaposhnik, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshaposhnik mshaposhnik added lgtm and removed lgtm labels Jan 12, 2025
@mshaposhnik
Copy link
Contributor

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@ifireball ifireball ifireball approved these changes

@hugares hugares Awaiting requested review from hugares

Assignees

@ifireball ifireball

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshaposhnik @ifireball