Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KONFLUX-5451): Expose metrics for Performance alerts #5235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rh-rahulshetty
Copy link
Contributor

This PR is a follow up on this task to expose new metrics for perf alerts related to the components ETCD, Kubernetes Job and Node Utilization.

Following new metrics are introduced as part of this PR:

  • etcd_disk_wal_fsync_duration_seconds_bucket
  • etcd_disk_backend_commit_duration_seconds_bucket
  • etcd_server_proposals_failed_total
  • etcd_network_peer_round_trip_time_seconds_bucket
  • kube_job_spec_completions
  • kube_job_status_succeeded
  • kube_job_status_failed
  • node_cpu_seconds_total {mode=idle}
  • node_memory_MemTotal_bytes
  • node_memory_MemAvailable_bytes

@openshift-ci openshift-ci bot requested review from eisraeli and martysp21 January 8, 2025 05:50
@rh-rahulshetty
Copy link
Contributor Author

Hello @jhutar @mftb @pacho-rh,
Could you please help review this change associated with Konflux Prometheus metric rules for the perf alerts.

Copy link
Contributor

@mftb mftb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

@pacho-rh pacho-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jhutar
Copy link
Member

jhutar commented Jan 9, 2025

/lgtm

@jhutar
Copy link
Member

jhutar commented Jan 9, 2025

/retest

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar, mftb, pacho-rh, rh-rahulshetty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mftb
Copy link
Contributor

mftb commented Jan 9, 2025

/retest

2 similar comments
@rh-rahulshetty
Copy link
Contributor Author

/retest

@mftb
Copy link
Contributor

mftb commented Jan 10, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants