-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kyverno to staging #5203
Open
sadlerap
wants to merge
1
commit into
redhat-appstudio:main
Choose a base branch
from
sadlerap:kyverno
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add kyverno to staging #5203
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
argo-cd-apps/base/member/infra-deployments/kyverno/kustomization.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| resources: | ||
| - kyverno.yaml |
47 changes: 47 additions & 0 deletions
47
argo-cd-apps/base/member/infra-deployments/kyverno/kyverno.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: ApplicationSet | ||
| metadata: | ||
| name: kyverno | ||
| labels: | ||
| noSourceTransform: "true" | ||
| spec: | ||
| generators: | ||
| - merge: | ||
| mergeKeys: | ||
| - nameNormalized | ||
| generators: | ||
| - clusters: | ||
| values: | ||
| sourceRoot: components/kyverno | ||
| environment: staging | ||
| clusterDir: "" | ||
| - list: | ||
| elements: [] | ||
| template: | ||
| metadata: | ||
| name: kyverno-{{nameNormalized}} | ||
| spec: | ||
| project: default | ||
| sources: | ||
| - chart: kyverno | ||
| repoURL: https://kyverno.github.io/kyverno/ | ||
| targetRevision: 3.3.4 | ||
| helm: | ||
| valueFiles: | ||
| - $values/{{values.sourceRoot}}/{{values.environment}}/values.yaml | ||
| destination: | ||
| namespace: konflux-kyverno | ||
| server: '{{server}}' | ||
| syncPolicy: | ||
| automated: | ||
| prune: true | ||
| selfHeal: true | ||
| syncOptions: | ||
| - CreateNamespace=true | ||
| - Replace=true # Recommended by upstream | ||
| retry: | ||
| limit: 50 | ||
| backoff: | ||
| duration: 10s | ||
| factor: 2 | ||
| maxDuration: 3m |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| admissionController: | ||
| replicas: 3 | ||
| backgroundController: | ||
| replicas: 3 | ||
| cleanupController: | ||
| replicas: 3 | ||
| reportsController: | ||
| replicas: 3 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some Notes on using ArgoCD. If I'm getting it correctly, we should either enable Replace in the syncOptions, and probably ignore diff in aggregated cluster roles or use server side apply.
Also, to avoid ArgoCD's Dasbhoard to be polluted with Kyverno's reports, we should tell ArgoCD to ignore reports globally by adding them under the
resource.exclusionsstanza in the ArgoCD ConfigMap.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ed5b523.
Do you know where the configmap is controlled or if it can be overridden by infra-deployments? I see an owner reference to argocd on the live versions of it (probably from the helm chart behind openshift-gitops), but I don't find a reference to it in this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about it. @hugares @manish-jangra @bamachrn can you help here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filariow @sadlerap the configs are stored on the internal gitlab and they utilize the
ArgoCDcustom resource. See:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not have time to look into this but the replace sync option is at the ArgoCD applications level so in infra-deployments. For the other "resource.exclusions", is it possible to also configure this at application level rather that globally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/129507 for staging, will file a separate MR for prod. Local testing by both @filariow and myself seemed to indicate that this will be safe to add, even to clusters that won't have kyverno installed.
I didn't come across a way to do resource exclusions on a per-application basis.