Skip to content

Remove PrefersNonDefaultGPU from desktop file #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

Jan200101
Copy link
Contributor

PrefersNonDefaultGPU is currently very broken, see ValveSoftware/steam-for-linux#9940

initially added by #1052

@qreeves qreeves requested a review from Calinou May 1, 2025 07:40
@qreeves
Copy link
Member

qreeves commented May 1, 2025

@Calinou You're probably more aware about the specifications than I, care to weigh in on this?

@qreeves
Copy link
Member

qreeves commented May 1, 2025

I'll note that on Windows, this is accomplished with a DLL export that is specifically about NVIDIA Optimus/AMD Express:

#ifdef WIN32
// Force Optimus setups to use the NVIDIA GPU
extern "C"
{
#ifdef __GNUC__
__attribute__((dllexport))
#else
__declspec(dllexport)
#endif
    DWORD NvOptimusEnablement = 1;

#ifdef __GNUC__
__attribute__((dllexport))
#else
__declspec(dllexport)
#endif
    DWORD AmdPowerXpressRequestHighPerformance = 1;
}
#endif

@Calinou
Copy link
Member

Calinou commented May 5, 2025

@Calinou You're probably more aware about the specifications than I, care to weigh in on this?

Yes, I agree it's best to remove it for now. Linux doesn't really have a good automatic solution for this just yet.

@qreeves qreeves removed the request for review from Calinou May 6, 2025 00:54
@qreeves qreeves merged commit a5e9eb8 into redeclipse:master May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants