Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeBSD support #2450

Merged
merged 21 commits into from
Nov 2, 2023
Merged

Add FreeBSD support #2450

merged 21 commits into from
Nov 2, 2023

Conversation

alonsobsd
Copy link
Contributor

Details:
Add/Edit some entries for include FreeBSD in tests

This was referenced Jun 2, 2023
Closed
Closed
@cyberbuff cyberbuff requested a review from josehelps June 5, 2023 15:56
@github-actions github-actions bot added the linux label Jun 8, 2023
@alonsobsd
Copy link
Contributor Author

It seems like you need add freebsd to https://github.com/redcanaryco/atomic-red-team/blob/master/bin/validate/atomic-red-team.schema.yaml

@cyberbuff
Copy link
Collaborator

It seems like you need add freebsd to https://github.com/redcanaryco/atomic-red-team/blob/master/bin/validate/atomic-red-team.schema.yaml

Here you go. Added the freebsd platform in the schema. Looks like you have to remove auto_generated_guid in the new atomics.

@cyberbuff cyberbuff removed the linux label Jun 9, 2023
@alonsobsd
Copy link
Contributor Author

It seems like you need add freebsd to https://github.com/redcanaryco/atomic-red-team/blob/master/bin/validate/atomic-red-team.schema.yaml

Here you go. Added the freebsd platform in the schema. Looks like you have to remove auto_generated_guid in the new atomics.

Done, Thanks!

@github-actions github-actions bot added the linux label Jun 9, 2023
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@svc-github-aws-opensource svc-github-aws-opensource force-pushed the master branch 3 times, most recently from 3ceb1e3 to 5e4a0ce Compare October 3, 2023 17:49
josehelps
josehelps approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@josehelps josehelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyberbuff cyberbuff requested a review from josehelps November 2, 2023 00:49
josehelps
josehelps approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@josehelps josehelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@josehelps josehelps merged commit 3ae4cec into redcanaryco:master Nov 2, 2023
@alonsobsd alonsobsd mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberbuff cyberbuff cyberbuff approved these changes

@josehelps josehelps josehelps approved these changes

Assignees

@josehelps josehelps

@MHaggis MHaggis

@clr2of8 clr2of8

@cyberbuff cyberbuff

Labels
freebsd linux macOS windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alonsobsd @cyberbuff @josehelps @MHaggis @clr2of8