T1046 - #2376
Merged
T1046 - #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add files via upload
Added test for the containers Made changes in the yaml file to incorporate containers as platforms  
adding src files for "Adding tests for container matrix"
|
Your description shows only the addition of a test in T1046 but your commit also includes a new test under T1612, is that intentional? |
|
Yes we have added a test to existing T1046 and included a new test under
T1612.
…On Mon, Mar 20, 2023 at 3:26 PM Carrie Roberts ***@***.***> wrote:
Your description shows only the addition of a test in T1046 but your
commit also includes a new test under T1612, is that intentional?
—
Reply to this email directly, view it on GitHub
<#2376 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4SFNLRNIF662SI7BO4SWYDW5DKR3ANCNFSM6AAAAAAV7F5PCM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@well123cs : can you please review the conflicts? you had another PR for T1612 which was merged : https://github.com/redcanaryco/atomic-red-team/pull/2375/files |
I have made the necessary changes. |
patel-bhavin
approved these changes
Apr 13, 2023
patel-bhavin
approved these changes
Apr 13, 2023
|
thank you for fixing up the PR and a new atomic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for the containers
Made changes in the yaml file to incorporate containers as platforms