-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from bundle-deps for odf-operator #509
Conversation
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
The odf-operator initially errors out due to missing CRDs, which prevents it from reaching a ready state and blocks the creation of the odf-dependencies subscription that brings these CRDs. By ignoring the NoKindMatchError for StorageClusterList, we allow the odf-operator to continue running and allow to create a odf-dependencies subscription. Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
replace localhost:5000 with quay.io before catalog change verification. The change is made within ci itself while pushing and pulling the bundle image locally to the CI. Signed-off-by: Nitin Goyal <[email protected]>
- Set catalog source name same as odf-operator sub for odf-depedencies sub while creating it. - Skip creation of subscriptions other than odf-depedencies. Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
oc wait immediately exit if the resource is not present on the cluster. Make sure resources are present before running oc wait. Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
odf-operator creates subscription for odf-dependencies and CRDs will become available only after odf-dependencies CSV is succeeded. We check the phase of odf-deps CSV to surface whether odf-op is ready to perform it's actions or not. Signed-off-by: Leela Venkaiah G <[email protected]>
90s for timeout is choosen based on a couple of observations that it took around a minute for InstallPlan to be realised as CSVs on the cluster. Signed-off-by: Leela Venkaiah G <[email protected]>
The CSVs check was implemted to make sure that all the required CRDS exists for the UI to proceed. But this check create problems in the cluster where the odf is being upgraded as odf-operator csv never gets into the Succeeded state because of the operator readiness check. Signed-off-by: Nitin Goyal <[email protected]>
18838e4
to
808d92d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/override ci/prow/ci-bundle-odf-operator-bundle The same PR was passed on the main, We don't need to retest. |
@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ci-bundle-odf-operator-bundle, ci/prow/images, ci/prow/odf-operator-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR containing the latest commits from bundle-deps branch