makefile: add target to create a new deps bundle #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
iamniting
force-pushed
the
bundle-deps
branch
10 times, most recently
from
f91ad49 to
76cf813
Compare
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
The odf-operator initially errors out due to missing CRDs, which prevents it from reaching a ready state and blocks the creation of the odf-dependencies subscription that brings these CRDs. By ignoring the NoKindMatchError for StorageClusterList, we allow the odf-operator to continue running and allow to create a odf-dependencies subscription. Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
replace localhost:5000 with quay.io before catalog change verification. The change is made within ci itself while pushing and pulling the bundle image locally to the CI. Signed-off-by: Nitin Goyal <[email protected]>
- Set catalog source name same as odf-operator sub for odf-depedencies sub while creating it. - Skip creation of subscriptions other than odf-depedencies. Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
oc wait immediately exit if the resource is not present on the cluster. Make sure resources are present before running oc wait. Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
iamniting
force-pushed
the
bundle-deps
branch
from
cf96289 to
5fa1200
Compare
odf-operator creates subscription for odf-dependencies and CRDs will become available only after odf-dependencies CSV is succeeded. We check the phase of odf-deps CSV to surface whether odf-op is ready to perform it's actions or not. Signed-off-by: Leela Venkaiah G <[email protected]>
90s for timeout is choosen based on a couple of observations that it took around a minute for InstallPlan to be realised as CSVs on the cluster. Signed-off-by: Leela Venkaiah G <[email protected]>
The CSVs check was implemted to make sure that all the required CRDS exists for the UI to proceed. But this check create problems in the cluster where the odf is being upgraded as odf-operator csv never gets into the Succeeded state because of the operator readiness check. Signed-off-by: Nitin Goyal <[email protected]>
iamniting
force-pushed
the
bundle-deps
branch
from
e448389 to
808d92d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: b-ranto, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 72594e8
into
red-hat-storage:main
17 checks passed
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nitin Goyal [email protected]