Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: adds proxy declaration for ROSA monitoring stack #387

Merged
merged 1 commit into from
Mar 27, 2024
Merged

console: adds proxy declaration for ROSA monitoring stack #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions console/console.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,16 @@ func GetConsolePluginCR(consolePort int, serviceNamespace string) *consolev1alph
},
Authorize: true,
},
{
Type: consolev1alpha1.ProxyTypeService,
Alias: "rosa-prometheus",
Service: consolev1alpha1.ConsolePluginProxyServiceConfig{
Name: "prometheus",
Namespace: serviceNamespace,
Port: 9339,
},
Authorize: false,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we maybe add it optionally (only if it is ROSA infra) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that requires us to detect platform and would add unnecessary complications to our code.

},
},
}
Expand Down
10 changes: 10 additions & 0 deletions controllers/clusterversion_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,16 @@ func (r *ClusterVersionReconciler) ensureConsolePlugin(clusterVersion string) er
},
Authorize: true,
},
{
Type: consolev1alpha1.ProxyTypeService,
Alias: "rosa-prometheus",
Service: consolev1alpha1.ConsolePluginProxyServiceConfig{
Name: "prometheus",
Namespace: OperatorNamespace,
Port: 9339,
},
Authorize: false,
},
}
}
return nil
Expand Down
Loading