controller: reuse the context from reconcile

[Madhu-1]

We dont need to create a new context for each time for a reconcile we should use the ctx from the Reconcile for all the dependent operations.

[Madhu-1]

/assign @iamniting

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Madhu-1
Once this PR has been reviewed and has the lgtm label, please ask for approval from iamniting. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Madhu-1]

@iamniting where i can find details about the test failure?

[iamniting]

Can we save the context to the recociler func and use it from there. I will save us from passing ctx here and there if the func is on top of reconciler struct.

[Madhu-1]

Can we save the context to the recociler func and use it from there. I will save us from passing ctx here and there if the func is on top of reconciler struct.

sorry didn't get the suggestion, Do you mean saving as a global variable? if yes, i would not do it as its against the practice. main goal is that we should not create context when reconciling instead we should use the context created for the Reconcile

[Madhu-1]

Can we save the context to the recociler func and use it from there. I will save us from passing ctx here and there if the func is on top of reconciler struct.

got it now, let me take that in to consideration and do it

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@Madhu-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/odf-operator-e2e-aws	f771169	link	true	/test odf-operator-e2e-aws
ci/prow/ci-bundle-odf-operator-bundle	f771169	link	true	/test ci-bundle-odf-operator-bundle

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.